-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use rust edition 2021 #591
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arrow
Changes to the arrow crate
arrow-flight
Changes to the arrow-flight crate
parquet
Changes to the parquet crate
parquet-derive
labels
Jul 22, 2021
jimexist
force-pushed
the
try-edition-2021
branch
7 times, most recently
from
July 27, 2021 13:00
d751ede
to
9481c49
Compare
jimexist
force-pushed
the
try-edition-2021
branch
from
August 3, 2021 09:18
9481c49
to
e260134
Compare
jimexist
force-pushed
the
try-edition-2021
branch
from
August 13, 2021 15:36
e260134
to
f65f720
Compare
jimexist
force-pushed
the
try-edition-2021
branch
3 times, most recently
from
August 29, 2021 15:12
2592319
to
438ed28
Compare
jimexist
force-pushed
the
try-edition-2021
branch
2 times, most recently
from
September 17, 2021 08:04
ab0e339
to
80ea7e6
Compare
jimexist
force-pushed
the
try-edition-2021
branch
from
September 26, 2021 04:21
80ea7e6
to
8295be7
Compare
jimexist
force-pushed
the
try-edition-2021
branch
3 times, most recently
from
October 14, 2021 01:00
0a9307f
to
b5fab3f
Compare
jimexist
force-pushed
the
try-edition-2021
branch
3 times, most recently
from
October 21, 2021 15:59
1873454
to
5b8de70
Compare
jimexist
force-pushed
the
try-edition-2021
branch
from
October 27, 2021 05:37
eb9380e
to
2024ae9
Compare
kszucs
added a commit
to apache/arrow
that referenced
this pull request
Oct 27, 2021
…ion docker image otherwise [downstream pull request][1] will be blocked at 1.55 rust version [1]: apache/arrow-rs#591 Closes #11557 from Jimexist/update-conda-integration Lead-authored-by: Jiayu Liu <jiayu.liu@airbnb.com> Co-authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Restarted the integration builds. |
jimexist
force-pushed
the
try-edition-2021
branch
from
October 27, 2021 14:11
2024ae9
to
20098f8
Compare
jimexist
force-pushed
the
try-edition-2021
branch
2 times, most recently
from
October 27, 2021 15:59
6a304fb
to
2321d78
Compare
for some reason the coverage tests env is still 1.55 |
This was referenced Oct 30, 2021
jimexist
force-pushed
the
try-edition-2021
branch
from
October 30, 2021 11:57
9736df5
to
b8b3188
Compare
Not sure why miri fails |
I am looking into it on #879 |
jimexist
force-pushed
the
try-edition-2021
branch
from
October 31, 2021 12:39
b8b3188
to
7fa0f77
Compare
with @alamb's help this is finally ready. I'm removing the line to ignore the Miri tests |
houqp
approved these changes
Oct 31, 2021
🎉 |
Merged
ViniciusSouzaRoque
pushed a commit
to s1mbi0se/arrow
that referenced
this pull request
Nov 3, 2021
…ion docker image otherwise [downstream pull request][1] will be blocked at 1.55 rust version [1]: apache/arrow-rs#591 Closes apache#11557 from Jimexist/update-conda-integration Lead-authored-by: Jiayu Liu <jiayu.liu@airbnb.com> Co-authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
arrow
Changes to the arrow crate
arrow-flight
Changes to the arrow-flight crate
parquet
Changes to the parquet crate
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Blocked by apache/arrow#11557
Related #714
Rationale for this change
https://blog.rust-lang.org/2021/05/11/edition-2021.html
What changes are included in this PR?
Are there any user-facing changes?