Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use rust edition 2021 #591

Merged
merged 1 commit into from
Nov 1, 2021
Merged

use rust edition 2021 #591

merged 1 commit into from
Nov 1, 2021

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Jul 22, 2021

Which issue does this PR close?

Closes #.
Blocked by apache/arrow#11557
Related #714

Rationale for this change

https://blog.rust-lang.org/2021/05/11/edition-2021.html

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate parquet Changes to the parquet crate parquet-derive labels Jul 22, 2021
@jimexist jimexist force-pushed the try-edition-2021 branch 7 times, most recently from d751ede to 9481c49 Compare July 27, 2021 13:00
@jimexist jimexist force-pushed the try-edition-2021 branch 3 times, most recently from 2592319 to 438ed28 Compare August 29, 2021 15:12
@jimexist jimexist force-pushed the try-edition-2021 branch 2 times, most recently from ab0e339 to 80ea7e6 Compare September 17, 2021 08:04
@jimexist jimexist force-pushed the try-edition-2021 branch 3 times, most recently from 0a9307f to b5fab3f Compare October 14, 2021 01:00
@jimexist jimexist force-pushed the try-edition-2021 branch 3 times, most recently from 1873454 to 5b8de70 Compare October 21, 2021 15:59
@jimexist jimexist marked this pull request as ready for review October 21, 2021 15:59
@jimexist jimexist changed the title try out edition 2021 use rust edition 2021 Oct 21, 2021
@jimexist jimexist requested a review from alamb October 27, 2021 05:38
kszucs added a commit to apache/arrow that referenced this pull request Oct 27, 2021
…ion docker image

otherwise [downstream pull request][1] will be blocked at 1.55 rust version

[1]: apache/arrow-rs#591

Closes #11557 from Jimexist/update-conda-integration

Lead-authored-by: Jiayu Liu <jiayu.liu@airbnb.com>
Co-authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
@kszucs
Copy link
Member

kszucs commented Oct 27, 2021

Restarted the integration builds.

@jimexist
Copy link
Member Author

Restarted the integration builds.

for some reason the coverage tests env is still 1.55

@jimexist
Copy link
Member Author

Not sure why miri fails

@alamb
Copy link
Contributor

alamb commented Oct 30, 2021

I am looking into it on #879

@jimexist
Copy link
Member Author

with @alamb's help this is finally ready. I'm removing the line to ignore the Miri tests

@jimexist jimexist merged commit f4fdc9c into apache:master Nov 1, 2021
@alamb
Copy link
Contributor

alamb commented Nov 1, 2021

🎉

@alamb alamb mentioned this pull request Nov 1, 2021
ViniciusSouzaRoque pushed a commit to s1mbi0se/arrow that referenced this pull request Nov 3, 2021
…ion docker image

otherwise [downstream pull request][1] will be blocked at 1.55 rust version

[1]: apache/arrow-rs#591

Closes apache#11557 from Jimexist/update-conda-integration

Lead-authored-by: Jiayu Liu <jiayu.liu@airbnb.com>
Co-authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants